fix: load entity factories #647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 3.0.x #647 +/- ##
============================================
+ Coverage 79.62% 80.90% +1.27%
- Complexity 493 494 +1
============================================
Files 73 73
Lines 1620 1629 +9
============================================
+ Hits 1290 1318 +28
+ Misses 330 311 -19 ☔ View full report in Codecov by Sentry. |
sstutz
force-pushed
the
fix/645
branch
2 times, most recently
from
b650efc to
0c724f5
Compare
sstutz
force-pushed
the
fix/645
branch
7 times, most recently
from
99ff041 to
afe5b4e
Compare
|
@TomHAnderson can u take a look again? |
TomHAnderson
reviewed
Dec 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #645
I've never used testbench so I am not 100% sure whether the configuration changes are correct but as far as I could tell it wasn't using the ./workbench directory at all hence the new
laravel: ./workbenchdirective.With the change to use the correct workbench directory I had to add a handful of new files and directories in order to make the pipeline happy so they are not really part of the scope of the fix but I had to add them anyway.