Allow customisation of Guzzle options #23
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Including the package in Laravel 5.5+ should trigger autodiscovery now. vendor:publish can be used to configure the Guzzle client.
Laravel has a minimum PHP requirement of 7.1.3, so let's use the phpunit version that supports that.
|
The CI builds seems to be partially failing due to PHP versions. Laravel currently requires 7.1 at the minimum, so I kept it at that, not sure how to solve this for the PR |
nmokkenstorm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some functionality and extendability that has been heavily requested. The feature I was missing to be able to use this package for a project I'm working on was being able to customise the options passed to Guzzle ( mostly SSL as requested here ).
The main change I made was depending on a
Guzzle\ClientInterfaceinstead of Client, and then making it possible to customise the binding resolution using a config file.As a side effect of some code cleanup I did it's now also possible to pass an array of URLs as requested here. If necessary I can split this PR in 2 parts, but looking at the outstanding PRs and issues I figured that doing it in one go might be more efficient.