Skip to content

chore: update the Foundation to v12.4.1 #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

chore: update the Foundation to v12.4.1 #110

wants to merge 3 commits into from

Conversation

owenvoke
Copy link
Member

No description provided.

@owenvoke owenvoke mentioned this pull request Mar 31, 2025
Draft
@fixr-kyle
Copy link

@owenvoke Regarding the errors that come up when running tests, specifically the EncryptCookies and WorkCommand classes, will these fixes be applied to the 11.x branch too? Asking because I just ran into both errors and didn't want to make a PR if that was the case.

@owenvoke
Copy link
Member Author

@fixr-kyle, ah, do those errors occur on 11.x as well? 👀 I'll PR the fix to the sync script and release a new patch.

@fixr-kyle
Copy link

@owenvoke They do, I just bumped one of my apps a few hours ago and saw laravel-zero/foundation changed from v11.5.0 to v11.44.2 and that's when my tests failed. The class check on those two files in particular resolves the issue.

@owenvoke
Copy link
Member Author

owenvoke commented Mar 31, 2025 •
edited
Loading

@fixr-kyle, Foundation v11.44.3 should resolve the issue. 👍🏻 Looks like the classes moved from Illuminate\Foundation\Http to Illuminate\Http 🙃

@fixr-kyle
Copy link

@owenvoke Awesome, tests pass. Thanks so much for the quick resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@owenvoke @fixr-kyle