support closure based global options

laravel · Mar 8, 2024 · b1f3f0d · b1f3f0d
1 parent 69e4085
commit b1f3f0d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Illuminate/Http/Client/Factory.php b/src/Illuminate/Http/Client/Factory.php
@@ -39,7 +39,7 @@ class Factory
     /**
      * The options to apply to every request.
      *
-     * @var array
+     * @var \Closure|array
      */
     protected $globalOptions = [];
 
@@ -133,7 +133,7 @@ public function globalResponseMiddleware($middleware)
     /**
      * Set the options to apply to every request.
      *
-     * @param  array  $options
+     * @param  \Closure|array  $options
      * @return $this
      */
     public function globalOptions($options)
@@ -420,7 +420,7 @@ public function recorded($callback = null)
      */
     protected function newPendingRequest()
     {
-        return (new PendingRequest($this, $this->globalMiddleware))->withOptions($this->globalOptions);
+        return (new PendingRequest($this, $this->globalMiddleware))->withOptions(value($this->globalOptions));
     }
 
     /**

diff --git a/tests/Http/HttpClientTest.php b/tests/Http/HttpClientTest.php
@@ -3011,7 +3011,7 @@ public function testItCanHaveGlobalDefaultValues()
         $this->assertFalse($allowRedirects);
         $this->assertSame(['true'], $headers['X-Foo']);
 
-        $factory->globalOptions([
+        $factory->globalOptions(fn () => [
             'timeout' => 10,
             'headers' => [
                 'X-Foo' => 'false',