[11.x] Add fromUrl() to Attachment (#52688)

* [11.x] Add `fromUrl()` to Attachment * CS Fixes * formatting --------- Co-authored-by: Tim MacDonald <[email protected]>
laravel · Sep 11, 2024 · dcb8163 · dcb8163
1 parent d9c322d
commit dcb8163
Show file tree

Hide file tree

Showing 2 changed files with 40 additions and 0 deletions.
diff --git a/src/Illuminate/Mail/Attachment.php b/src/Illuminate/Mail/Attachment.php
@@ -55,6 +55,17 @@ public static function fromPath($path)
         return new static(fn ($attachment, $pathStrategy) => $pathStrategy($path, $attachment));
     }
 
+    /**
+     * Create a mail attachment from a URL.
+     *
+     * @param  string  $url
+     * @return static
+     */
+    public static function fromUrl($url)
+    {
+        return static::fromPath($url);
+    }
+
     /**
      * Create a mail attachment from in-memory data.
      *

diff --git a/tests/Mail/AttachableTest.php b/tests/Mail/AttachableTest.php
@@ -109,4 +109,33 @@ public function toMailAttachment()
             99,
         ], $notification->dataArgs);
     }
+
+    public function testFromUrlMethod()
+    {
+        $mailable = new class extends Mailable
+        {
+            public function build()
+            {
+                $this->attach(new class implements Attachable
+                {
+                    public function toMailAttachment()
+                    {
+                        return Attachment::fromUrl('https://example.com/file.pdf')
+                            ->as('example.pdf')
+                            ->withMime('application/pdf');
+                    }
+                });
+            }
+        };
+
+        $mailable->build();
+
+        $this->assertSame([
+            'file' => 'https://example.com/file.pdf',
+            'options' => [
+                'as' => 'example.pdf',
+                'mime' => 'application/pdf',
+            ],
+        ], $mailable->attachments[0]);
+    }
 }