Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Refactored chunk method using Null coalescing operator #49314

Conversation

kitamatsu-rui
Copy link

I've simplified and improved the readability of the chunk method in Foundation/vite.php by incorporating the null coalescing operator.

@kitamatsu-rui kitamatsu-rui changed the title Refactored Chunk Method using Null Coalescing Operator Refactored chunk method using Null coalescing operator Dec 11, 2023
@driesvints driesvints changed the title Refactored chunk method using Null coalescing operator [10.x] Refactored chunk method using Null coalescing operator Dec 11, 2023
@browner12
Copy link
Contributor

Taylor rarely merges things like this. But be aware, it also technically changes behavior. Null coalesce does an isset and null check, where the previous code was only doing an isset check.

@kitamatsu-rui kitamatsu-rui deleted the Tenth0-refactor/chunk-method-null-coalescing branch December 12, 2023 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants