[10.x] Model::preventAccessingMissingAttributes() raises exception for castable attributes that were not retrieved
#49470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmastech
changed the title
Model::preventAccessingMissingAttributes() raises exception when retrieving attribute that has a castModel::preventAccessingMissingAttributes() raises exception for castable attributes that were not retrieved
|
This would break a lot of use cases where cast objects are "virtual" - think about an address value object that is resolved from multiple attributes. It never actually exists in the attributes array itself. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To resolve #49434
Previously, a castable attribute that was not retrieved from the DB would not raise this exception. By checking that the attribute was retrieved before attempting to cast the attribute, the preventAccessingMissingAttributes works intuitively in such a case.