Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed file loader namespace overrides reduce call #49597 #49568

Closed
wants to merge 2 commits into from
Closed

Fixed file loader namespace overrides reduce call #49597 #49568

wants to merge 2 commits into from

Conversation

aprokopenko
Copy link

Fix for: #49567

GrahamCampbell
GrahamCampbell requested changes Jan 3, 2024
View reviewed changes
Copy link
Member

@GrahamCampbell GrahamCampbell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is missing tests.

@taylorotwell
Copy link
Member

Indeed - no tests so unsure if anything is fixed.

@aprokopenko
Copy link
Author

@taylorotwell ,
Would it be added if I add tests? I don't understand the flow, because the issue was moved to discussions with no more comments on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GrahamCampbell GrahamCampbell GrahamCampbell requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aprokopenko @taylorotwell @GrahamCampbell