Check that the app logger has a driver() function, preventing fatal errors #49635
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that when the application logger is used and workers with a Redis connection are registered, it is assumed that the existing logger implements a 'driver' function, which then gets called for another method. Whenever a logger instance is attached that does not have the 'driver' function, the code breaks with a fatal error:
In QueueServiceProvider.php line 201:
Call to undefined method Monolog\Logger::driver()
Unsure of what the $resetScope callback is actually used for, I found that adding an additional check to see if the 'driver' function exists is small enough of a change that creating a new unit tests would be overkill. This pull request also does not break any currently running tests.