[10.x] Update routes and events "is cached" check to is_file #49680
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The method that checks for a cached configuration file uses is_file (and was changed a few years back from file_exists during a mass update). These methods weren't updated as they weren't directly calling file_exists, but under the hood that's effectively all this method does after looking up the Filesystem service. This brings these methods in line with other usages of is_file and trims an unnecessary service lookup from the call stack.
|
Going to leave as is in case the container binding has been changed in existing apps. |
|
Fair enough. How about for 11.x? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method that checks for a cached configuration file uses is_file (and was changed a few years back from file_exists during a mass update). These methods weren't updated as they weren't directly calling file_exists, but under the hood that's effectively all this method does after looking up the Filesystem service.
This brings these methods in line with other usages of is_file and trims an unnecessary service lookup from the call stack.