Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] Fix docs ResourceCollection and JsonCollection #49700

Conversation

Kenini1805
Copy link
Contributor

No description provided.

@Kenini1805 Kenini1805 force-pushed the fix-document-resource-colection-and-json-collection branch from 86bdee6 to fa9e91a Compare January 16, 2024 09:38
@Kenini1805 Kenini1805 force-pushed the fix-document-resource-colection-and-json-collection branch from fa9e91a to f381168 Compare January 16, 2024 09:41
@driesvints driesvints changed the title [10.x]: Fix docs ResourceCollection and JsonCollection [10.x] Fix docs ResourceCollection and JsonCollection Jan 16, 2024
@taylorotwell
Copy link
Member

I am closing this pull request because it lacks sufficient explanation, tests, or both. It is difficult for us to merge pull requests without these things because the change may introduce breaking changes to the framework.

Feel free to re-submit your change with a thorough explanation of the feature and tests - integration tests are preferred over unit tests. Please include it's benefit to end users; the reasons it does not break any existing features; how it makes building web applications easier, etc.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants