Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.x] fix Rule::unless for callable #49724

Closed
wants to merge 1 commit into from
Closed

Conversation

dbakan
Copy link
Contributor

@dbakan dbakan commented Jan 17, 2024

When $condition is a callable then (! $condition) does not invert the callbacks result, but is always false instead. It is easier to flip $defaultRulesand $rules.

Copy link

Thanks for submitting a PR!

In order to review and merge PRs most efficiently, we require that all PRs grant maintainer edit access before we review them. For information on how to do this, see the relevant GitHub documentation. Additionally, GitHub doesn't allow maintainer permissions from organization accounts. Please resubmit this PR from a personal GitHub account with maintainer permissions enabled.

@github-actions github-actions bot closed this Jan 17, 2024
@dbakan dbakan deleted the rule-unless branch January 18, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant