[11.x] Fix adding constraints on sqlite #49728
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SQLite schema grammar silently ignores adding primary key and foreign key constraints when altering table, this PR fixes that. I understand that this was to preventing failure when running tests using SQLite, but please consider that it's more important to let the user know that these constraints are not actually added. A simple workaround for users that use SQLite for running tests is to simply check for their database before adding constraints:
Or alternatively if #49723 merged: