Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[10.x] Do not resolve posix calls on Windows #50023

Closed
wants to merge 1 commit into from
Closed

[10.x] Do not resolve posix calls on Windows #50023

wants to merge 1 commit into from

Conversation

driesvints
Copy link
Member

@driesvints driesvints commented Feb 9, 2024 •
edited
Loading

Resolves #50022

@driesvints driesvints changed the title Do not resolve posix calls on Windows [10.x] Do not resolve posix calls on Windows Feb 9, 2024
This was referenced Feb 9, 2024
Merged
Closed
@driesvints driesvints closed this Feb 9, 2024
@driesvints driesvints deleted the fix-posix-calls-windows branch February 9, 2024 07:50
@Tofandel
Copy link
Contributor

Tofandel commented Feb 9, 2024

Wouldn't checking if the constant is defined better than checking if it's windows? If pcntl is not installed I think this would be thrown as well on linux

@driesvints
Copy link
Member Author

@Tofandel we have a different solution: #50024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Undefined constant "Illuminate\Foundation\Console\SIGTERM"
2 participants
@driesvints @Tofandel