Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix]Fix Artisan Serve command issue when using stderr logging #50033

Closed
wants to merge 2 commits into from

Conversation

cezarpopa
Copy link

@cezarpopa cezarpopa commented Feb 9, 2024

Hi,

i hope all is well, as this is my first PR on the project, I believe that the patch added covers the case where the request is missing a port number and follows the given guidelines in the pull request template.

If i messed up something badly apologies for that and feel free to close the PR, i am not extremely familiar with the project.
I followed the steps mentioned here: #49927 to reproduce the issue.

Thank you,
Cezar

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants