Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v11] Spark is not a framework dependency, middleware does not exist #50304

Closed
wants to merge 1 commit into from

Conversation

pxpm
Copy link
Contributor

@pxpm pxpm commented Feb 28, 2024

I was bugged with #50298

I think closing the issue was an overlook, as I still think this does not belong here.

I should have created the PR at first to better illustrate the issue, sorry for that 🙏

Cheers

@browner12
Copy link
Contributor

Are you manually attaching that middleware to some routes? Or is this on a clean install?

@pxpm
Copy link
Contributor Author

pxpm commented Feb 28, 2024

Are you manually attaching that middleware to some routes? Or is this on a clean install?

I am not touching that middleware in any place.

I am pushing other middlewares in the ServiceProvider with Router::pushMiddlewareToGroup(), not sure if that can be anything related here. Those middlewares are not the spark one, or I am not trying to set another subscribed middleware.

Edit: just to add that I cannot consistently reproduce this.

@pxpm
Copy link
Contributor Author

pxpm commented Feb 28, 2024

Ok, I was able to find what was logging that into my app logs.

My editor static analyser was the culprit. I was able to reproduce the issue by forcing it to re-index the project files.

Whenever it reindexes that class the error is thrown, because "technically" the class should exists as subscribed is a perfectly valid key from that array. One should know before hand that to use "subscribed" alias you must first install the spark package, but what's the point ?
Can't that alias be registered by spark package ?

Feel free to close if you think it's ok as it is, but from my POV, even if I found this "by chance" and shouldn't be getting this error unless "i try to use the alias without installing the package", it makes more sense that this package alias to be registered by the package itself.

Cheers

@taylorotwell
Copy link
Member

Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants