Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Prompts user to run migrations on install:api Artisan command #50315

Merged
merged 4 commits into from
Mar 4, 2024

Conversation

nunomaduro
Copy link
Member

This pull request prompts user to run migrations on install:api Artisan command:

Screenshot 2024-02-29 at 14 59 33

@hafezdivandari
Copy link
Contributor

Would you please consider adding --passport option to install Laravel Passport?

@driesvints
Copy link
Member

@hafezdivandari I don't think we should do that at this point. Otherwise we'll be adding flags for every other package as well.

@hafezdivandari
Copy link
Contributor

But we have 2 first-party packages for API auth?
Having an option to choose between Sanctum or Passport when running install:api improves DX.

@driesvints
Copy link
Member

@hafezdivandari the packages are two very different things. One does PAT and the other OAuth 2. We don't recommend using the PAT from passport any longer.

@hafezdivandari
Copy link
Contributor

hafezdivandari commented Mar 1, 2024

@driesvints I know the difference, but both of them have api guard, and we are talking about install:api command.

The main purpose of install:api is to add routes/api.php file and also add it on app.php bootstrap file. To install Laravel Passport I have to this manually or remove Sanctum after calling install:api then call passport:install.

@taylorotwell taylorotwell merged commit c089bf1 into master Mar 4, 2024
21 checks passed
@taylorotwell taylorotwell deleted the feat/improve-api-install branch March 4, 2024 15:01
@taylorotwell
Copy link
Member

@hafezdivandari PRs welcome on that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants