Mark config options for smart merge #50364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof of concept that would allow "smart merging" of configuration options. Right now Laravel 11 "shallow" merges application config with the frame defaults. However, many config files like database, filesystems, mail, etc have a "main" option which is nested. This PR creates a registry of those "main" options and does an additional merge for them.
This would allow developers to further slim their configuration files while reducing the possibility of removing a core configuration option. For example, only customizing
mysqldatabase driver, while still usingsqlitefor testing. Or adding additionaldisks, but still using the defaultlocalors3disks.