Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix race condition with withoutOverlapping in Console tasks #50391

Closed
wants to merge 1 commit into from

Conversation

mattford
Copy link

@mattford mattford commented Mar 6, 2024

Changes the logic of the Lock::get method so that if a callable is passed, it simply checks whether the lock is available instead of actually acquiring it, this resolves the race condition reported in #50330

Existing behaviour is preserved, as previously the lock was acquired then immediately released if a callable was passed.

Copy link

github-actions bot commented Mar 6, 2024

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

@mattford mattford closed this Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant