Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Adds Enums folder to make:enum command #50411

Merged
merged 6 commits into from
Mar 8, 2024

Conversation

milwad-dev
Copy link
Contributor

#50394

In our previous PR, we didn't include the option to create enums in the Enums folder or App folder. However, we have now added this feature! If someone would like to create an enum file in the Enums folder, they just need to create a folder named Enums :)
Like models

@milwad-dev milwad-dev marked this pull request as draft March 7, 2024 17:53
@milwad-dev
Copy link
Contributor Author

@driesvints
I think we need to re-run the tests.
Also, I can't access to the Styleci!!

@driesvints
Copy link
Member

@milwad-dev seems tests still fail

@milwad-dev milwad-dev marked this pull request as ready for review March 8, 2024 11:32
@martinbean
Copy link
Contributor

@milwad-dev Would be nice if this were configurable. I use Enumerations as my directory/namespace name, for example.

@milwad-dev
Copy link
Contributor Author

"We cannot do that because if we do it for one command, we will have to do it for all commands such as models

@taylorotwell taylorotwell merged commit b6075ed into laravel:11.x Mar 8, 2024
28 checks passed
@taylorotwell
Copy link
Member

Added Enumerations support @martinbean

@dvlpr91
Copy link
Contributor

dvlpr91 commented Mar 15, 2024

I was expecting this command to default to the 'Enums' folder, regardless of whether it exists or not... Sad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants