Fix DATABASE_URL parsing in ConfigurationUrlParser->getDatabase()

[HenkPoley]

Not sure how this ever worked.

Maybe it used to recieve $url['path'] => '=database_name' from DB_DATABASE=database_name in .env. So chopping off the first character ('=') would work. But that's now how it works today.

Connecting to the database without setting the DATABASE_URL, and using the array syntax from config/database.php still works.

Found in: laravel/docs#9459

[HenkPoley]

Hmm, I see this breaks some database support. I guess I'll have to dig into that before this can be merged.

My current use case is for Microsoft SQL Server (sqldrv).

[driesvints]

Feel free to resend this once you have passing tests 👍

[HenkPoley]

The reason I'm submitting this is that \Illuminate\Database\Connectors\SqlServerConnector::buildConnectString() I'm seeing

"sqlsrv:Server=127.0.0.1,1433;Database=erver=127.0.0.1,1433;Database=database_name"

Everything at and after spurious 'erver=' part is not right, of course. I think it kind of works on some databases, because it kind of defines Database= twice.

ConfigurationUrlParser->getDatabase() is the place there 'Server=..' is converted to 'erver=..'. And I think it ought to return the database name.

I'm not very well versed with the insides of Laravel. So @driesvints, I think I will need some help in figuring it out.

Right now I don't have more time to look into it.

[HenkPoley]

For reference, the above bug in \Illuminate\Support\ConfigurationUrlParser::getDatabase() is currently in laravel/framework v10.47.0

It affects both sqlsrv and mysql, when using DATABASE_URL= in .env

[HenkPoley]

@mathieutu since you wrote \Illuminate\Support\ConfigurationUrlParser::getDatabase(), 5 years ago, maybe you know how to fix it?