[10.x] Fix for sortByDesc ignoring multiple attributes #50431
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
sortByDesc()
on a collection, it should match the signature of thesortBy()
method.The
sortBy()
method accepts an array of attributes to sort a collection in 2 different formats:[['attribute1', 'asc|desc'], ['attribute2', 'asc|desc']]
['attribute1', 'attribute2']
which is then transformed to[['attribute1', 'asc'], ['attribute2', 'asc']]
in thesortByMany()
method.Essentially, when you pass in an array as the first parameter, you need to be explicit about sorting direction, or it will sort in ascending order. Also, when you pass array as the first parameter, it ignores the
$descending
flag in thesortBy()
method.Currently, the
sortByDesc()
method just callssortBy()
and sets the$descending
flag to true. So when you pass in an array as the first parameter, if you are not specific, it sorts in ascending order.This PR resolves this issue by converting the array to the more descriptive format and forcing it to sort in descending order.