[11.x] Improves errors

[nunomaduro]

No description provided.

[taylorotwell]

@nunomaduro does this need to also reset on any job events?

[nunomaduro]

I've replicated what ignition is doing: https://github.com/spatie/laravel-ignition/blob/9c60d929a91803dee7e47614c37cbe6d3f2b1e2c/src/IgnitionServiceProvider.php#L311C1-L311C43.

[taylorotwell]

@nunomaduro I think this is good pending those weird HTML formatting things I pointed out and single comment above.

[mfn]

I've got failing tests over in rebing/graphql-laravel#1137 (automated weekly)

I think it's related to this PR, because it fails on a class which was introduced here.

Any ideas?

[driesvints]

@mfn gonna be super hard to deduct what's going on without more info. Best that you attempt a minimum repro example with the installer:

laravel new bug-report --github="--public"

[mfn]

The minimal reproducer is:

• clone https://github.com/rebing/graphql-laravel
• (composer update)
• run the test \Rebing\GraphQL\Tests\Database\EmptyQueryTest::testNoExplicitContentType

It didn't fail before, now with the latest L11 version it does. I.e. the test matrix with prefer-lowest is fine

[driesvints]

I'm sorry @mfn but we can't go off on a third party repo. We'll need a clear way to reproduce this in a Laravel project.

[mfn]

No worries, I figured it out!

It was a improper use of testbench to configure my test: I was setting app.debug flag to true, but when \Illuminate\Foundation\Providers\FoundationServiceProvider::registerExceptionRenderer is called, the debug flag was not (yet) set: more detailed explanation and the fix.

[NickSdot]

@nunomaduro I am missing two functionalities I pretty much appreciated before:

1. Error lines where clickable to open in editor
2. Output of dd() and dump() were visible

Before I am going to dig: should these features work or were they left out intantionaly?