Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Change closure to arrow function in Dispatcher #51891

Closed
wants to merge 1 commit into from

Conversation

azibom
Copy link

@azibom azibom commented Jun 23, 2024

Hi
I changed closure to arrow function in Dispatcher to make the code more readable.

@MrPunyapal
Copy link
Contributor

Arrow functions must return something 👀
It's not the return type friendly.
And we need a future of types 🤞

@rodrigopedra
Copy link
Contributor

to make the code more readable

It is perfectly readable in its current state.

Furthermore, before the callback returned null, now it returns mixed.

@driesvints
Copy link
Member

This code unfortunately isn't the same as @rodrigopedra indicated.

@driesvints driesvints closed this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants