Check if the cache files are really removed

[tolnaiz]

Currently, config:clear, event:clear, and route:clear do not check if the cache files were actually removed.

If the user running the command has only read permissions for these files, the commands simply return a “… cache cleared successfully.” message without any indication that the files weren't removed.

This problem exists because Filesystem::delete doesn't throw an exception, just returns a boolean indicating whether unlink ran successfully on all the files provided. This return value is then ignored in the command handle.

For reference, here is the filesystem delete function which is called by the clear commands:

framework/src/Illuminate/Filesystem/Filesystem.php

Lines 300 to 319 in a2f2dc2

	public function delete($paths)
	{
	$paths = is_array($paths) ? $paths : func_get_args();
	$success = true;
	foreach ($paths as $path) {
	try {
	if (@unlink($path)) {
	clearstatcache(false, $path);
	} else {
	$success = false;
	}
	} catch (ErrorException) {
	$success = false;
	}
	}
	return $success;
	}

Since this change might be considered breaking, I made the pull request to the master branch.

[taylorotwell]

Just leaving as is for now.