refactor #52071
Closed
refactor #52071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since Laravel 11.x, the AuthorizesRequests trait was removed from base controller class. Also the base controller class no longer extends the Illuminate\Routing\Controllers\Middleware; These two above are important for authorizeResource method to work properly in controllers. There are a lot of question to why authorizeResource is removed even in the documentation. see: laravel#50673 laravel#50552 https://laracasts.com/discuss/channels/laravel/help-on-authorizeresource-alternative-in-laravel-11 laravel#50566 The same solution is proposed in all the above. The problem with that solution is that middleware cannot be defined in controllers this way : https://laravel.com/docs/11.x/controllers#controller-middleware . As recommended in the documentation, because the middleware implementation the controller class will clash with the one in Illuminate\Routing\Controllers\Middleware. I am guessing this is why that method was removed in documentation and use of gate is promoted. This commit also makes use of gates and removes the need to extend Illuminate\Routing\Controllers\Middleware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update to #52067