[11.x] Explicit id field when reading session from database

[GromNaN]

I would like to fix the database query used by the DatabaseSessionHandler in order to make it compatible with a MongoDB connection provided by the package mongodb/laravel-mongodb.

The ID field name is hardcoded in the class DatabaseSessionHandler,

framework/src/Illuminate/Session/DatabaseSessionHandler.php

Line 158 in 68e88bb

return $this->getQuery()->insert(Arr::set($payload, 'id', $sessionId));

framework/src/Illuminate/Session/DatabaseSessionHandler.php

Line 173 in 68e88bb

return $this->getQuery()->where('id', $sessionId)->update($payload);

framework/src/Illuminate/Session/DatabaseSessionHandler.php

Line 269 in 68e88bb

$this->getQuery()->where('id', $sessionId)->delete();

But for the read method, the class relies on Query\Builder::find implementation:

framework/src/Illuminate/Database/Query/Builder.php

Lines 2899 to 2902 in 68e88bb

	public function find($id, $columns = ['*'])
	{
	return $this->where('id', '=', $id)->first($columns);
	}

MongoDB's default ID field is _id, so we overloaded Query\Builder::find() in the MongoDB package. The query uses the _id field, this is necessary for Eloquent models with MongoDB: https://github.com/mongodb/laravel-mongodb/blob/f654b833d31ec3cac96887e6db61c5fef4f68b4a/src/Query/Builder.php#L228-L231

The issue is that documents are stored by DatabaseSessionHandler with the field id, but queried with the field _id.
I hope this PR can be accepted to fix mongodb/laravel-mongodb#3022.

[taylorotwell]

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!