Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.x] Allow to set a name when registering a blade extension #52246

Closed
wants to merge 2 commits into from

Conversation

artrz
Copy link
Contributor

@artrz artrz commented Jul 23, 2024

This change allows to set a name when registering a blade extension, which can be used to override or control extensions added by third party packages.

@taylorotwell
Copy link
Member

What is the benefit / use case?

@artrz
Copy link
Contributor Author

artrz commented Jul 24, 2024

@taylorotwell If packages extending the blade compiler like https://github.com/conedevelopment/blade-filters/blob/master/src/BladeFiltersServiceProvider.php could add a name it would be easy to override the registered callable.

@artrz artrz marked this pull request as draft July 24, 2024 07:48
@driesvints
Copy link
Member

@artrz did you need a new review? Make sure to mark the PR as ready if you need one.

@artrz artrz marked this pull request as ready for review July 26, 2024 18:48
@artrz
Copy link
Contributor Author

artrz commented Jul 26, 2024

Thanks for the heads-up @driesvints

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

@artrz artrz deleted the blade-named-extensions branch July 29, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants