[11.x] Support Parent Classes for Event Listeners #52278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
vbergerondev
force-pushed
the
11.x-add-support-to-listen-on-parent-event-class
branch
from
cfc74f4 to
ce9630b
Compare
vbergerondev
changed the title
|
I think I would hesitate to change this on a patch release. We would probably be safer adding an interface to Fortify events. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Taylor,
I've made a slight modification to the
addInterfaceListenersmethod to also support parent classes. This enhancement is useful for listening to a group of events that extend the same parent class (e.g.,TwoFactorAuthenticationEventabstract class from Fortify).This change is necessary for me to create database logs when specific events from Fortify are dispatched. While it's currently possible to listen to interfaces, Fortify events do not implement any interfaces.
Thanks!