Fix stub files management #52328
Closed
Fix stub files management #52328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored console commands to use a `resolveStubPath` method for determining stub file locations. This enhances code maintainability and allows for custom stub paths, if specified.
Removed unnecessary line breaks in the return statement of getStub() method to simplify the code and enhance readability. This change does not affect the functionality but improves code clarity.
Reorder the list of stub file path entries in the array in alphabetical order for better clarity. This change aims to improve readability and maintain consistency within the file.
Included additional stubs such as channel.stub, interface.stub, model.morph-pivot.stub, rule.implicit.stub, and view.stub. This expands the range of template files available for publication via the stub publish command.
|
That is intentional. We only publish the commonly customized stubs. |
|
@taylorotwell Right, I skimmed over the sentence "To accomplish this, you may use the stub:publish command to publish the most common stubs to your application so that you can customize them". But why is that, if I may ask? Why are only the most frequently used stubs published? Thank you very much for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When executing the command
php artisan stub:publishI noticed that not all stubs are published. After checking, I realised that many paths are missing in the fileFoundation/Console/StubPublishCommand.php. I also refactored console commands to use aresolveStubPathmethod for determining stub file locations. This enhances code maintainability and allows for custom stub paths, if specified.I originally encountered the problem in a Laravel 11 project. If this change was made correctly for Laravel 10, the changes from my branch
fix/update-stub-files-managementcould be adopted for version 11.