[Feature]: Adding Callback to Set Locale

[joaopalopes24]

I want to add the locale dynamically within the Number class.

Example:

use Illuminate\Support\Number;
 
/**
 * Bootstrap any application services.
 */
public function boot(): void
{
    Number::setLocale(function (): string {
        return Auth::user()?->locale ?? config('app.locale');
    });
}

[github-actions]

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.

[devajmeireles]

I want to add the locale dynamically within the Number class.

Example:

use Illuminate\Support\Number;
 
/**
 * Bootstrap any application services.
 */
public function boot(): void
{
    Number::setLocale(function (): string {
        return Auth::user()?->locale ?? config('app.locale');
    });
}

You can use withLocale for a single-use only or useLocale:

Number::useLocale(Auth::user()?->locale ?? config('app.locale'));

[joaopalopes24]

Number::useLocale(Auth::user()?->locale ?? config('app.locale'));

This doesn't work because Auth::user() in this case will always be null within the AppServiceProvider.

[devajmeireles]

Number::useLocale(Auth::user()?->locale ?? config('app.locale'));

This doesn't work because Auth::user() in this case will always be null within the AppServiceProvider.

Have you tried using middleware? Setting this at the service provider is more logical for situations where the locale comes from a config rather than the user.

Furthermore, your PR breaks principles by using the ensureIntlExtensionIsInstalled function to define the language. This function should only be used to handle intl checking I guess.

[joaopalopes24]

Why would I make middleware, when I can define a callback in my service provider, just like Laravel uses in other resources?

https://laravel.com/docs/11.x/passwords#reset-link-customization

It's a feature that I find interesting.

[devajmeireles]

Why would I make middleware, when I can define a callback in my service provider, just like Laravel uses in other resources?

https://laravel.com/docs/11.x/passwords#reset-link-customization

It's a feature that I find interesting.

I mentioned the middleware thinking about getting the current authenticated user, that doesn't exist in the service provider layer.