[11.x] Don't touch BelongsTo relationship when it doesn't exist #52407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, MorphTo and BelongsToMany check for relation existence before sending the update query to the database. This adds that check to the BelongsTo relationship. `getParentKey()` can be used to find the child foreign key value
patrickomeara
force-pushed
the
dont-touch-belongs-to-when-relation-does-not-exist
branch
from
dbfd1c7 to
37b15c1
Compare
RazinTeqB
added a commit
to RazinTeqB/framework
that referenced
this pull request
Aug 28, 2024
…st (laravel#52407)" This reverts commit dd649c6.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
MorphToandBelongsToManycheck for relation existence before sending the update query to the database.This adds that check to the
BelongsTorelationship.I found this when trawling through query logs. Nullable belongs to relationship were producing a lot of unnecessary update queries
Additionally,
getParentKey()can be used to find the child foreign key value.