Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✅ [11.x] Ask About secret for application DownCommand #52476

Closed
wants to merge 1 commit into from
Closed

✅ [11.x] Ask About secret for application DownCommand #52476

wants to merge 1 commit into from

Conversation

tarikmanoar
Copy link

This PR will assist you in entering maintenance mode without the need for commands such as php artisan down, while also inquiring about secrets.

image

Previously, you were limited to passing the secret argument for establishing a secret. With the growing popularity of the new prompts, this enhancement will facilitate the setup of a secret.

Prompt user to set up a secret code for DownCommand if there is not option passed
@Jubeki
Copy link
Contributor

Jubeki commented Aug 14, 2024

This is probably a bad idea to do this on a minor release, because there are probably many applications which do php artisan down and php artisan up in their deployment script. Which would now require interaction which will not happen and therefor breaking the deployment script. (At least this is my understanding of the prompting for any argument)

@tarikmanoar
Copy link
Author

This is probably a bad idea to do this on a minor release, because there are probably many applications which do php artisan down and php artisan up in their deployment script. Which would now require interaction which will not happen and therefor breaking the deployment script. (At least this is my understanding of the prompting for any argument)

It seems like a lot of folks rely on the secret option for the down command since you can run php artisan down --secret=laravel or simply php artisan down and follow the prompts. Personally, I often forget to include the secret when I use the down command, which can be a bit of a hassle.

@Jubeki
Copy link
Contributor

Jubeki commented Aug 14, 2024

While I agree with the interactive context and asking for an optional secret.

The problem are deployment scripts without interaction, where now after an update all deployment scripts which simply use php artisan down without any further parameters would break. This should not simply happen on a minor release.

@donnysim
Copy link
Contributor

Theoretically a lot might rely on the secret, but for those who don't and/or have it integrated into a deployment pipeline or such this will break it, and in some cases in a very unpleasant way.

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants