Update thousand symbol to match SI/NIST standard lowercase #52533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted, whenCounted (#51342)
…52337) * Added ability to define exceptions as unreportable using ShouldntReport interface * Update ShouldntReport.php * formatting --------- Co-authored-by: Taylor Otwell <[email protected]>
# Conflicts: # CHANGELOG.md # src/Illuminate/Foundation/Application.php # tests/Database/DatabaseConcernsHasAttributesTest.php
* add `testFromRemoveHeader` * add `withoutHeaders` * add `testFromRemoveHeaders` * Update MakesHttpRequestsTest.php
…ass is left out of the message array (#52451) * Account for anonymous function custom validation in the validator Issue: #52437 * Revert changes in validator, adjust message formatter When the message is an array, but the rule isn't set, it should default to $rule->message() rather than the array of messages * move this test and adjust add the message array * Add styleci recommendations * stylceci also wanted some single quotes
#52465) * Create Notification make command markdown name placeholder from Notification name * fix code style * formatting --------- Co-authored-by: Taylor Otwell <[email protected]>
* Add `forceDestroy` to `SoftDeletes` * Update Model.php --------- Co-authored-by: Taylor Otwell <[email protected]>
Add test and fix syntax
* feat: Add clear stopping point for recursion * style: fix styleci * Update MySqlSchemaState.php * Update DatabaseMySqlSchemaStateTest.php * Update MySqlSchemaState.php --------- Co-authored-by: Taylor Otwell <[email protected]>
* Run prepareNestedBatches on append/prependToChain * Cleanup leftover import * Update chain method * Update Queueable.php --------- Co-authored-by: Taylor Otwell <[email protected]>
* fix db:show with counts option * fix db:table * add more info * formatting * fix connection name and table size * Update ShowCommand.php --------- Co-authored-by: Taylor Otwell <[email protected]>
* Constrain key when asserting database has against a model * Use already constrained database has methods * Using a model instance that isn't saved to the database should fail
* Added `between` tests * Added `between` assertion * pint * pint * formatting * min max --------- Co-authored-by: Taylor Otwell <[email protected]>
* Adds asset prefetching strategies * Formatting * Rename config * Use low fetch priority * formatting * formatting --------- Co-authored-by: Taylor Otwell <[email protected]>
* feat: support attributes in `app()->call()` * feat: support attributes in route dependencies resolution * style: apply fixes from style-ci
* feat: make HigherOrderCollectionProxy generic via template types * Add type tests for HigherOrderCollectionProxy
…search()` and `multisearch()` functions (#51669) * Update PromptsAssertionTest.php * Update ConfiguresPrompts.php * Update PromptsAssertionTest.php * Add tests for search and multisearch assertions * Formatting * Formatting * Add `expectsSearch` method --------- Co-authored-by: Jess Archer <[email protected]>
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
GrahamCampbell
requested changes
Aug 20, 2024
that makes perfect sense - however, I'm just trying to figure out if there are other changes needed and if it's wanted. The units for billion and quintillion are also wrong. I'm also not sure you can chain the prefixes e.g., kP - still trying to get a confirmation out of the NIST/SI sites. Wondering if the units should be set to the NIST/SI standard but have a way to provide your own to the |
|
On review I feel this function is about general numbers, e.g., Users, and not numbers with units, e.g., grams. Having "we have 1B users" makes more sense than "we have 1G users". As such I'm going to close this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to both SI and NIST standards the unit for thousand should be a lowercase k: NIST (see section Capitalization).
This updates the two functions to follow these standards.
I appreciate that there is a 'colloquial' variant for monetary and distance to use the uppercase K, e.g., $10K or a 10K run.
However, these are the exceptions and not the norm.
The use of the
abbreviate()function currently precludes the use of something like:Number::abbreviate(10_000).'g';or any other standard unit.I couldn't find any reference to a previous discussion, so apologies if I missed something.