[12.x] Add missing methods to the Illuminate\Contracts\Container\Container interface
#52543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted, whenCounted (#51342)
…52337) * Added ability to define exceptions as unreportable using ShouldntReport interface * Update ShouldntReport.php * formatting --------- Co-authored-by: Taylor Otwell <[email protected]>
* Add `forceDestroy` to `SoftDeletes` * Update Model.php --------- Co-authored-by: Taylor Otwell <[email protected]>
Add test and fix syntax
* feat: Add clear stopping point for recursion * style: fix styleci * Update MySqlSchemaState.php * Update DatabaseMySqlSchemaStateTest.php * Update MySqlSchemaState.php --------- Co-authored-by: Taylor Otwell <[email protected]>
* Run prepareNestedBatches on append/prependToChain * Cleanup leftover import * Update chain method * Update Queueable.php --------- Co-authored-by: Taylor Otwell <[email protected]>
* fix db:show with counts option * fix db:table * add more info * formatting * fix connection name and table size * Update ShowCommand.php --------- Co-authored-by: Taylor Otwell <[email protected]>
* Constrain key when asserting database has against a model * Use already constrained database has methods * Using a model instance that isn't saved to the database should fail
* Added `between` tests * Added `between` assertion * pint * pint * formatting * min max --------- Co-authored-by: Taylor Otwell <[email protected]>
* Adds asset prefetching strategies * Formatting * Rename config * Use low fetch priority * formatting * formatting --------- Co-authored-by: Taylor Otwell <[email protected]>
* feat: support attributes in `app()->call()` * feat: support attributes in route dependencies resolution * style: apply fixes from style-ci
* feat: make HigherOrderCollectionProxy generic via template types * Add type tests for HigherOrderCollectionProxy
…search()` and `multisearch()` functions (#51669) * Update PromptsAssertionTest.php * Update ConfiguresPrompts.php * Update PromptsAssertionTest.php * Add tests for search and multisearch assertions * Formatting * Formatting * Add `expectsSearch` method --------- Co-authored-by: Jess Archer <[email protected]>
subhamchbty
changed the title
Illuminate\Contracts\Container\Container interfaceIlluminate\Contracts\Container\Container interface
subhamchbty
changed the title
Illuminate\Contracts\Container\Container interfaceIlluminate\Contracts\Container\Container interface
|
Hey, you can't make changes to an interface on a minor release, because there could be apps which implement the interface and would not be confronted with a breaking change. These changes can only happen in major versions (master branch). |
|
@Jubeki Shall I change the base branch then? Or can you please suggest what I should do? |
|
Yeah changing the base branch to master would be okay, because that would be the branch for the next major version 12.x |
subhamchbty
changed the title
Illuminate\Contracts\Container\Container interfaceIlluminate\Contracts\Container\Container interface
|
Hi @Jubeki, I've create another PR as you suggested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refresh($abstract, $target, $method)rebinding($abstract, Closure $callback)Proposed Changes
The changes have been made to the
src/Illuminate/Contracts/Container/Container.phpfile, where the new methods have been added to theIlluminate\Contracts\Container\Containerinterface.Potential Impact
These changes are intended to be backward-compatible and should not break existing code that relies on the
Illuminate\Contracts\Container\Containerinterface. They provide additional capabilities that can be optionally utilized by developers.