[11.x] Added Number::isBetween() method

[soltmar]

This PR adds new isBetween method to Number class.

Method tests if given number is between given min and max. There is also 4th $inclusive parameter where we can decide wether min and max should be inclusive or not.

I've had this function for years in my helpers.php file and though that since we have Number class for a while now it may be worth to include it there so others can benefit from it.

I'm wondering why nobody came up with this simple method before. Maybe there was a reason, if this is the case could you point me to the PR so I can see explanation please ?

I know this is very basic functionality but believe this will improve code readability and see it being used a lot by Laravel community.

Thanks

[taylorotwell]

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If applicable, please consider releasing your code as a package so that the community can still take advantage of your contributions!

[soltmar]

It doesn't make sense to create a package from what I've done here. It's not a big change / addition and Number class seem like a perfect place for this.