Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[12x.] Add month enum to scheduler cron method yearlyOn() #53976

Closed
wants to merge 4 commits into from
Closed

[12x.] Add month enum to scheduler cron method yearlyOn() #53976

wants to merge 4 commits into from
+24 −3

Conversation

shaedrich
Copy link
Contributor

Continuation of #53961

@shaedrich shaedrich changed the title Add month enum to scheduler cron method yearlyOn() [12x.] Add month enum to scheduler cron method yearlyOn() Dec 19, 2024
@shaedrich
Remove unused import
3f4605a 
Since enum is only type-hinted in PHPDoc block
@shaedrich
Type-hint enum in respective Facade
5bd666a
@taylorotwell
Copy link
Member

This stuff doesn't really need to go to master.

@shaedrich
Copy link
Contributor Author

shaedrich commented Dec 19, 2024 •
edited
Loading

This stuff doesn't really need to go to master.

@taylorotwell So, 11.x then? oO

master's my better safe than sorry here 😅

@shaedrich shaedrich mentioned this pull request Dec 19, 2024
Open
@shaedrich
Copy link
Contributor Author

see #53983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crynobone crynobone crynobone left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shaedrich @taylorotwell @crynobone