Add support for sending raw (non-encoded) attachments in Resend mail driver #55803
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for sending raw (non-base64 encoded) attachments in the Resend mail driver, which is useful for cases like sending
.ics(calendar) files.The Resend API currently does not properly handle base64-encoded
.icsattachments. As a workaround, this PR allows certain attachments (e.g., with thetext/calendarMIME type) to be sent as raw content without encoding.Changes
ResendTransportto skip encoding when the attachment has a media type oftext/calendarWhy this is needed
.icsattachments properly..icsfile to be sent as plain text for compatibility with calendar clients.I couldn't find any tests for the Resend driver?