[12.x] isSoftDeletable(), isPrunable(), and isMassPrunable() to model class #56060
+39
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cosmastech
reviewed
Jun 17, 2025
| */ | ||
| protected function isPrunable(): bool | ||
| { | ||
| return in_array(Prunable::class, class_uses_recursive(static::class)) || static::isMassPrunable(); |
There was a problem hiding this comment.
thought: It would be great if there were a ClassUsesRecursive once helper that would store these values for the lifetime of a request.
Written out as you have here, we can see that we're going to loop through all the traits of the class and its parent-classes twice if the class is MassPrunable but not Prunable.
There was a problem hiding this comment.
Good point 👍🏻 I had a similar idea—looks like there's an appetite for this 🚀
cosmastech
reviewed
Jun 17, 2025
Co-authored-by: Luke Kuzmish <[email protected]> See laravel#55274 See laravel#56060 (comment)
taylorotwell
added a commit
to illuminate/database
that referenced
this pull request
Jun 17, 2025
… class (#56060) * feat(database): ✨ Add isSoftDeletable(), isPrunable(), and isMassPrunable() to model class * fix(database): 🐛 Call model method instead of command method * Restore "only check for soft deletes once when mass-pruning" Co-authored-by: Luke Kuzmish <[email protected]> See laravel/framework#55274 See laravel/framework#56060 (comment) * Fix typo Follow-up to 07520f2225a78a183c6d02da11f662ddf207657d * formatting * fix test --------- Co-authored-by: Taylor Otwell <[email protected]>
taylorotwell
added a commit
to illuminate/routing
that referenced
this pull request
Jun 17, 2025
… class (#56060) * feat(database): ✨ Add isSoftDeletable(), isPrunable(), and isMassPrunable() to model class * fix(database): 🐛 Call model method instead of command method * Restore "only check for soft deletes once when mass-pruning" Co-authored-by: Luke Kuzmish <[email protected]> See laravel/framework#55274 See laravel/framework#56060 (comment) * Fix typo Follow-up to 07520f2225a78a183c6d02da11f662ddf207657d * formatting * fix test --------- Co-authored-by: Taylor Otwell <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Benefits
✅ Encapsulated implementation details: Unrelated places don't need to concern themselves with how it's done
✅ Single source of truth: Now easily refactorable, only one place needs to be changed
✅ DRY
Alternatives