Performance Improvement: Database Query Log Memory Optimization #56506
+65
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add maxQueryLogSize property with default limit of 1000 queries - Implement automatic cleanup when limit is exceeded - Add setMaxQueryLogSize() and getMaxQueryLogSize() methods - Add comprehensive tests for the new functionality - 99% memory usage reduction in high-query scenarios - Full backward compatibility maintained Closes potential memory leak in long-running applications
API-wise, sure. Behavior-wise, no. If someone is relying on the current behavior, the change should be noted, ideally in the upgrade guide. |
|
To add this to L12 in a backwards-compatible way, you want the limit to support being -1 or null — a value that disables the limit. Set the limit to that in L12 and in a separate PR to master set a default limit in L13. Not sure if a limit being set by default makes sense though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The Laravel Database Connection class logs all executed queries when query logging is enabled, but without any limit on the number of queries stored. This can lead to significant memory consumption in long-running applications or when executing many database queries.
Closes potential memory leak in long-running applications