[12.x] add allDirectories() method to Filesytem
#57565
Merged
+32
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we already have
files(),allFiles(), anddirectories(), so this method completes the set and allows us to recursively get all directories within a given path.both
files()andallFiles()return an array ofSplFileInfoobjects, whiledirectories()maps the results to the path name and returns an array of strings. I was torn between wanting to be consistent with thedirectories()method here, but also wanting to return the full object to allow the calling code to decide what it needed. Ideally all 4 methods would return an array ofSplFileInfoobjects, but that would be a BC. I landed on providing the objects back, but open to suggestions.