Typescript UI update #1578
Closed
Typescript UI update #1578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Migrate all Vue components from Options API to Composition API with TypeScript - Add TypeScript configuration files (tsconfig.json, tsconfig.node.json) - Convert JavaScript files to TypeScript (.js to .ts) - Add type definitions for all data structures - Update build configuration to support TypeScript - Add type checking to build process - Suppress Sass deprecation warnings from Bootstrap - Update package.json with TypeScript dependencies
- Set up Playwright for visual regression testing - Add comprehensive tests covering all main screens - Create GitHub Actions for automated testing - Add workflow for updating snapshots via PR comments - Fix primary color to match original (#7746ec) - Update Chart.js configuration for v2 compatibility - Add TypeScript declarations for Chart.js v2 - Include baseline snapshots for all screens - Add documentation for visual testing workflow This ensures the TypeScript conversion maintains pixel-perfect compatibility with the original JavaScript version.
- Update upload-artifact from v3 to v4 - Update cache action from v3 to v4 This fixes the deprecation warnings from GitHub Actions.
|
Thanks for submitting a PR! Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert Horizon UI to TypeScript
This PR modernizes the Laravel Horizon frontend by converting all Vue components from
JavaScript to TypeScript, improving type safety and developer experience.
Changes Made
TypeScript Migration
Components Converted
Testing Infrastructure
Technical Details
Testing
Visual regression tests ensure pixel-perfect compatibility with the original UI:
To run tests locally:
npm run test:visual
Breaking Changes
None. This is a pure frontend refactor with no changes to:
Future Improvements
This TypeScript foundation enables: