Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Pest option back in Laravel app and improve pest experience #413

Merged
merged 1 commit into from
Mar 13, 2025

Conversation

tnylea
Copy link
Contributor

@tnylea tnylea commented Mar 12, 2025

This PR will add the pest option back to the Laravel installer and run drift in a default Laravel app to convert the PHPunit class-based tests to Pest.

@nunomaduro and I collaborated to create a version that would not require the starter kits to need the Pest.php file in the test directory but will init that file and make necessary modifications if the user selects pest as their testing option.

After this PR is merged in and a new version of Herd has been released, we can then merge in the following Pull Requests for each starter kit:

laravel/react-starter-kit#82
laravel/react-starter-kit#82
laravel/livewire-starter-kit#61

@Jubeki
Copy link
Contributor

Jubeki commented Mar 12, 2025

Hey @tnylea thanks for all the good work.

Maybe it would be a great idea to add a notice if a new version of the installer is available, because many developers do not upgrade their global composer dependencies regularly.

You can find some ideas here, though there would be considerations needed for Herd support:
#308

@taylorotwell taylorotwell merged commit f82fdf6 into master Mar 13, 2025
21 checks passed
@taylorotwell taylorotwell deleted the feat/improve-pest-experience branch March 13, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants