[2.x] Support both CommonMark v1 & v2 (#845)

* Fix commonmark 2.0 changes breaking TOS/PP * Fix composer.json * Use Str::markdown Co-authored-by: Mike Roquemore <[email protected]>
laravel · Jul 28, 2021 · 7446fc7 · 7446fc7
1 parent b33a95d
commit 7446fc7
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 28 deletions.
diff --git a/src/Http/Controllers/Inertia/PrivacyPolicyController.php b/src/Http/Controllers/Inertia/PrivacyPolicyController.php
@@ -4,11 +4,9 @@
 
 use Illuminate\Http\Request;
 use Illuminate\Routing\Controller;
+use Illuminate\Support\Str;
 use Inertia\Inertia;
 use Laravel\Jetstream\Jetstream;
-use League\CommonMark\CommonMarkConverter;
-use League\CommonMark\Environment;
-use League\CommonMark\Extension\GithubFlavoredMarkdownExtension;
 
 class PrivacyPolicyController extends Controller
 {
@@ -22,11 +20,8 @@ public function show(Request $request)
     {
         $policyFile = Jetstream::localizedMarkdownPath('policy.md');
 
-        $environment = Environment::createCommonMarkEnvironment();
-        $environment->addExtension(new GithubFlavoredMarkdownExtension());
-
         return Inertia::render('PrivacyPolicy', [
-            'policy' => (new CommonMarkConverter([], $environment))->convertToHtml(file_get_contents($policyFile)),
+            'policy' => Str::markdown(file_get_contents($policyFile)),
         ]);
     }
 }
diff --git a/src/Http/Controllers/Inertia/TermsOfServiceController.php b/src/Http/Controllers/Inertia/TermsOfServiceController.php
@@ -4,11 +4,9 @@
 
 use Illuminate\Http\Request;
 use Illuminate\Routing\Controller;
+use Illuminate\Support\Str;
 use Inertia\Inertia;
 use Laravel\Jetstream\Jetstream;
-use League\CommonMark\CommonMarkConverter;
-use League\CommonMark\Environment;
-use League\CommonMark\Extension\GithubFlavoredMarkdownExtension;
 
 class TermsOfServiceController extends Controller
 {
@@ -22,11 +20,8 @@ public function show(Request $request)
     {
         $termsFile = Jetstream::localizedMarkdownPath('terms.md');
 
-        $environment = Environment::createCommonMarkEnvironment();
-        $environment->addExtension(new GithubFlavoredMarkdownExtension());
-
         return Inertia::render('TermsOfService', [
-            'terms' => (new CommonMarkConverter([], $environment))->convertToHtml(file_get_contents($termsFile)),
+            'terms' => Str::markdown(file_get_contents($termsFile)),
         ]);
     }
 }
diff --git a/src/Http/Controllers/Livewire/PrivacyPolicyController.php b/src/Http/Controllers/Livewire/PrivacyPolicyController.php
@@ -4,10 +4,8 @@
 
 use Illuminate\Http\Request;
 use Illuminate\Routing\Controller;
+use Illuminate\Support\Str;
 use Laravel\Jetstream\Jetstream;
-use League\CommonMark\CommonMarkConverter;
-use League\CommonMark\Environment;
-use League\CommonMark\Extension\GithubFlavoredMarkdownExtension;
 
 class PrivacyPolicyController extends Controller
 {
@@ -21,11 +19,8 @@ public function show(Request $request)
     {
         $policyFile = Jetstream::localizedMarkdownPath('policy.md');
 
-        $environment = Environment::createCommonMarkEnvironment();
-        $environment->addExtension(new GithubFlavoredMarkdownExtension());
-
         return view('policy', [
-            'policy' => (new CommonMarkConverter([], $environment))->convertToHtml(file_get_contents($policyFile)),
+            'policy' => Str::markdown(file_get_contents($policyFile)),
         ]);
     }
 }
diff --git a/src/Http/Controllers/Livewire/TermsOfServiceController.php b/src/Http/Controllers/Livewire/TermsOfServiceController.php
@@ -4,10 +4,8 @@
 
 use Illuminate\Http\Request;
 use Illuminate\Routing\Controller;
+use Illuminate\Support\Str;
 use Laravel\Jetstream\Jetstream;
-use League\CommonMark\CommonMarkConverter;
-use League\CommonMark\Environment;
-use League\CommonMark\Extension\GithubFlavoredMarkdownExtension;
 
 class TermsOfServiceController extends Controller
 {
@@ -21,11 +19,8 @@ public function show(Request $request)
     {
         $termsFile = Jetstream::localizedMarkdownPath('terms.md');
 
-        $environment = Environment::createCommonMarkEnvironment();
-        $environment->addExtension(new GithubFlavoredMarkdownExtension());
-
         return view('terms', [
-            'terms' => (new CommonMarkConverter([], $environment))->convertToHtml(file_get_contents($termsFile)),
+            'terms' => Str::markdown(file_get_contents($termsFile)),
         ]);
     }
 }