Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update meta titles to match the current page title #330

Closed
wants to merge 1 commit into from

Conversation

zcuric
Copy link

@zcuric zcuric commented May 9, 2024

This PR

  • Sets meta:title to match the current page title
  • Sets meta:og:title to match current page title
  • Sets meta:twiiter:title to match current page title

This PR is basically a KISS version of #263 PR to just improve sharing across platforms when sharing docs.

@taylorotwell
Copy link
Member

Thanks for your pull request to Laravel!

Unfortunately, I'm going to delay merging this code for now. To preserve our ability to adequately maintain the framework, we need to be very careful regarding the amount of code we include.

If possible, please consider releasing your code as a package so that the community can still take advantage of your contributions!

If you feel absolutely certain that this code corrects a bug in the framework, please "@" mention me in a follow-up comment with further explanation so that GitHub will send me a notification of your response.

@zcuric
Copy link
Author

zcuric commented May 14, 2024

@taylorotwell thanks for the response, this seems to me like an automated message. This actually fixes an issue with meta tags when part of the documents has been shared for example in Slack or on socials. Particularly it fixes this situation:
image
Title for this shared piece should be Events - Laravel 11.x - The PHP Framework For Web Artisans but it pulls title from meta title instead of HTML title tag. This small change address that.

It's a small change to the website/docs, not the framework. If you have a smarter way of fixing this, please do, I just wanted to contribute with a small fix.

Thank you for amazing work, Laravel and the whole ecosystem. God speed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants