Use ConfigRepository methods instead of directly accessing the raw internal array #284
+2
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses the methods provided by the Config Repository to interact with the config data instead of directly accessing the raw internal array of data.
This fixes support for applications that might not store the config values in the exact internal array structure that we are expecting (i.e. Winter CMS, which stores everything under namespaced keys, where top level keys end up having "*::" prefixed to their key in the internal array.
The switch to accessing the raw array internals of the Config Repository occurred in cd09cd0#diff-f418488ec2f97353bcc9eaf797747e525178b3746278ca795966c7b0aea2c883L65-L302 and it appears to have unintentional side effects.
Without this change I'll have to do something truly horrible in Winter's
ConfigRepository
: