Use self instead of static for resolving recorder config (#50)

laravel · Nov 3, 2023 · ab91bfa · ab91bfa
1 parent 083b02e
commit ab91bfa
Show file tree

Hide file tree

Showing 8 changed files with 13 additions and 13 deletions.
diff --git a/src/Recorders/CacheInteractions.php b/src/Recorders/CacheInteractions.php
@@ -68,7 +68,7 @@ public function record(CacheHit|CacheMissed $event): ?Entry
     protected function normalizeKey(string $key): Closure
     {
         return function () use ($key) {
-            foreach ($this->config->get('pulse.recorders.'.static::class.'.groups') as $pattern => $replacement) {
+            foreach ($this->config->get('pulse.recorders.'.self::class.'.groups') as $pattern => $replacement) {
                 $normalized = preg_replace($pattern, $replacement, $key, count: $count);
 
                 if ($count > 0 && $normalized !== null) {

diff --git a/src/Recorders/Concerns/Ignores.php b/src/Recorders/Concerns/Ignores.php
@@ -10,7 +10,7 @@ trait Ignores
     protected function shouldIgnore(string $value): bool
     {
         // @phpstan-ignore argument.templateType, argument.templateType
-        return collect($this->config->get('pulse.recorders.'.static::class.'.ignore'))
+        return collect($this->config->get('pulse.recorders.'.self::class.'.ignore'))
             ->contains(fn (string $pattern) => preg_match($pattern, $value));
     }
 }
diff --git a/src/Recorders/Concerns/Sampling.php b/src/Recorders/Concerns/Sampling.php
@@ -11,7 +11,7 @@ trait Sampling
      */
     protected function shouldSample(): bool
     {
-        $rate = $this->config->get('pulse.recorders.'.static::class.'.sample_rate');
+        $rate = $this->config->get('pulse.recorders.'.self::class.'.sample_rate');
 
         return Lottery::odds($rate)->choose();
     }
@@ -21,7 +21,7 @@ protected function shouldSample(): bool
      */
     protected function shouldSampleDeterministically(string $seed): bool
     {
-        $rate = $this->config->get('pulse.recorders.'.static::class.'.sample_rate');
+        $rate = $this->config->get('pulse.recorders.'.self::class.'.sample_rate');
 
         $value = hexdec(md5($seed)) / pow(16, 32); // Scale to 0-1
 

diff --git a/src/Recorders/Jobs.php b/src/Recorders/Jobs.php
@@ -120,7 +120,7 @@ public function record(JobReleasedAfterException|JobFailed|JobProcessed|JobProce
                         'date' => $now->toDateTimeString(),
                         'released_at' => $now->toDateTimeString(),
                         'duration' => $duration = $this->lastJobStartedProcessingAt->diffInMilliseconds($now), // @phpstan-ignore method.nonObject
-                        'slow' => $duration >= $this->config->get('pulse.recorders.'.static::class.'.threshold'),
+                        'slow' => $duration >= $this->config->get('pulse.recorders.'.self::class.'.threshold'),
                     ],
                 ),
                 new Entry($this->table, [
@@ -143,7 +143,7 @@ public function record(JobReleasedAfterException|JobFailed|JobProcessed|JobProce
                     'date' => $now->toDateTimeString(),
                     'processed_at' => $now->toDateTimeString(),
                     'duration' => $duration = $this->lastJobStartedProcessingAt->diffInMilliseconds($now), // @phpstan-ignore method.nonObject
-                    'slow' => $duration >= $this->config->get('pulse.recorders.'.static::class.'.threshold'),
+                    'slow' => $duration >= $this->config->get('pulse.recorders.'.self::class.'.threshold'),
                 ],
             ), fn () => $this->lastJobStartedProcessingAt = null);
         }
@@ -156,7 +156,7 @@ public function record(JobReleasedAfterException|JobFailed|JobProcessed|JobProce
                     'date' => $now->toDateTimeString(),
                     'failed_at' => $now->toDateTimeString(),
                     'duration' => $duration = $this->lastJobStartedProcessingAt->diffInMilliseconds($now), // @phpstan-ignore method.nonObject
-                    'slow' => $duration >= $this->config->get('pulse.recorders.'.static::class.'.threshold'),
+                    'slow' => $duration >= $this->config->get('pulse.recorders.'.self::class.'.threshold'),
                 ],
             ), fn () => $this->lastJobStartedProcessingAt = null);
         }

diff --git a/src/Recorders/OutgoingRequests.php b/src/Recorders/OutgoingRequests.php
@@ -65,7 +65,7 @@ public function record(RequestInterface $request, CarbonImmutable $startedAt): ?
             'date' => $startedAt->toDateTimeString(),
             'duration' => $duration = $startedAt->diffInMilliseconds($endedAt),
             'user_id' => $this->pulse->authenticatedUserIdResolver(),
-            'slow' => $duration >= $this->config->get('pulse.recorders.'.static::class.'.threshold'),
+            'slow' => $duration >= $this->config->get('pulse.recorders.'.self::class.'.threshold'),
         ]);
     }
 
@@ -79,7 +79,7 @@ protected function normalizeUri(RequestInterface $request): Closure
         $uri = $request->getUri();
 
         return function () use ($method, $uri) {
-            foreach ($this->config->get('pulse.recorders.'.static::class.'.groups') as $pattern => $replacement) {
+            foreach ($this->config->get('pulse.recorders.'.self::class.'.groups') as $pattern => $replacement) {
                 $normalized = preg_replace($pattern, $replacement, $uri, count: $count);
 
                 if ($count > 0 && $normalized !== null) {

diff --git a/src/Recorders/Requests.php b/src/Recorders/Requests.php
@@ -80,7 +80,7 @@ public function record(Carbon $startedAt, Request $request, Response $response):
             'route' => $request->method().' '.$path.($via ? " ($via)" : ''),
             'duration' => $duration = $startedAt->diffInMilliseconds(),
             'user_id' => $this->pulse->authenticatedUserIdResolver(),
-            'slow' => $duration >= $this->config->get('pulse.recorders.'.static::class.'.threshold'),
+            'slow' => $duration >= $this->config->get('pulse.recorders.'.self::class.'.threshold'),
         ]);
     }
 }
diff --git a/src/Recorders/SlowQueries.php b/src/Recorders/SlowQueries.php
@@ -46,7 +46,7 @@ public function record(QueryExecuted $event): ?Entry
     {
         $now = new CarbonImmutable();
 
-        if ($event->time < $this->config->get('pulse.recorders.'.static::class.'.threshold')) {
+        if ($event->time < $this->config->get('pulse.recorders.'.self::class.'.threshold')) {
             return null;
         }
 

diff --git a/src/Recorders/SystemStats.php b/src/Recorders/SystemStats.php
@@ -44,7 +44,7 @@ public function record(Beat $event): ?Entry
 
         return new Entry($this->table, [
             'date' => $event->time->toDateTimeString(),
-            'server' => $this->config->get('pulse.recorders.'.static::class.'.server_name'),
+            'server' => $this->config->get('pulse.recorders.'.self::class.'.server_name'),
             ...match (PHP_OS_FAMILY) {
                 'Darwin' => [
                     'cpu_percent' => (int) `top -l 1 | grep -E "^CPU" | tail -1 | awk '{ print $3 + $5 }'`,
@@ -58,7 +58,7 @@ public function record(Beat $event): ?Entry
                 ],
                 default => throw new RuntimeException('The pulse:check command does not currently support '.PHP_OS_FAMILY),
             },
-            'storage' => collect($this->config->get('pulse.recorders.'.static::class.'.directories')) // @phpstan-ignore argument.templateType, argument.templateType
+            'storage' => collect($this->config->get('pulse.recorders.'.self::class.'.directories')) // @phpstan-ignore argument.templateType, argument.templateType
                 ->map(fn (string $directory) => [
                     'directory' => $directory,
                     'total' => $total = intval(round(disk_total_space($directory) / 1024 / 1024)), // MB