[1.x] Prevent pulse:check from filling the file cache
#260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jessarcher
force-pushed
the
fix-pulse-check-cache-growing
branch
from
1b5d7da to
cfe8bd5
Compare
|
Building failing until #261 is merged. |
timacdonald
reviewed
Dec 27, 2023
timacdonald
approved these changes
Dec 27, 2023
jessarcher
force-pushed
the
fix-pulse-check-cache-growing
branch
from
c62eb7f to
3300f20
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue when using the file cache driver where the cache locks would continue growing on disk. This is due to the file cache driver not automatically removing files when the cache item has expired.
Fixes #238