Fix bug related to readonly properties #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
According to this comment, let me take another look at the code. |
|
Based on laravel/framework#51877 (comment) I'll close this for now but definitely appreciate the help here 👍 Just want to prevent this from getting merged unwanted. Feel free to continue the discussion and send in a new PR if you figure things out. Thanks! |
|
@driesvints Never mind. Based on laravel/framework#51877 (comment), the fix is feasible. Should I go ahead and resubmit the same PR? |
|
@rust17 re-opened this one for ya 👍 |
|
Alright, just give me some time. |
|
Thank you for the background information and the test case included in this PR. This test case shows that removing the fix code reproduces the bug caused by the readonly property, while adding the code resolves it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fix this issue where an exception is thrown during the unserialize process when
Bus::chainhandles a class that includes a readonly property. The exception message is:Cannot modify readonly property Illuminate\Tests\Integration\Queue\ReadonlyEnumTestJob::$enum.