Ignore invalid paths (#1478)

laravel · May 7, 2024 · 0f3ab1f · 0f3ab1f
1 parent a21d0bf
commit 0f3ab1f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 0 deletions.
diff --git a/cli/Valet/Server.php b/cli/Valet/Server.php
@@ -160,6 +160,10 @@ public function sitePath(string $siteName): ?string
         $domain = static::domainFromSiteName($siteName);
 
         foreach ($this->config['paths'] as $path) {
+            if (! is_dir($path)) {
+                continue;
+            }
+
             $handle = opendir($path);
 
             if ($handle === false) {

diff --git a/tests/ServerTest.php b/tests/ServerTest.php
@@ -90,6 +90,13 @@ public function test_it_returns_null_default_site_path_if_not_set()
         $this->assertNull($server->defaultSitePath());
     }
 
+    public function test_it_ignores_invalid_paths()
+    {
+        $server = new Server(['paths' => ['fake' => __DIR__.'/invalid_path']]);
+
+        $this->assertNull($server->sitePath('tighten'));
+    }
+
     public function test_it_tests_whether_host_is_ip_address()
     {
         $this->assertTrue(Server::hostIsIpAddress('192.168.1.1'));